points by WesolyKubeczek 3 days ago | 0 comments
What if I plant a hook on the engineer’s laptop that will slightly modify their commits in such a way that eventually I smuggle malicious code over? First, exfiltrate the code over to me, learn from previous commits, start poisoning. Stamped by the CI, no less. In the days of slop PRs thousands of lines each shouldn’t be even too hard.
The point is that at some point you do need to open the door and let the code in.
[–] stickfigure 3 days ago
The company should require both automated and human review of PRs. Mine does.
[–] mianos 3 days ago
This is the standard at most professional companies but it's now becoming a problem due to AI and undisciplined people submitting 10,000 lines MRs.
[–] zaphirplane 3 days ago
mine mandates no security bugs in PR :)
[–] WesolyKubeczek 3 days ago
"too long, LGTM, now buzz off"
[–] baal80spam 3 days ago
Well, that's still a human review. If something breaks, you (as in: this reviewer) is at least partly responsible.
[–] zaphirplane 3 days ago