Hacker News

points by ShadowOfThePit 4 days ago | 0 comments

holy shit this so funny, using the pull request to review himself

I thought it was pretty common? Pre-LLMs I've always opened PRs to self-review before asking anyone to review it (sometimes leaving myself comments), now I'm also having an agent review it and leaving its own comments that I might answer, seems like a very normal thing to do.

I do ensure these self-conversations are resolved so that the PR is clean when I ask other reviewers to have a look, and I don't think I'd do that on an open-source project. But I'm very much shrugging at this practice.

[–] mtlynch 4 days ago

I think what OP did is poor practice. From the maintainer side, how are they supposed to know when the PR is ready for review? Are the maintainers expected to keep checking in on the contributors' threads with themselves to make sure everything is wrapped up?

To me, there's two things you can mean with a PR:

- Open a normal PR: I personally attest to the quality of the code, and I'm ready for the maintainer to review/merge it.

- Open a draft PR: I have questions about proceeding and want to show you a work in progress to give context.

Any kind of intermediate work to prepare it for the maintainers should happen in a fork, not adding noise in the official repo. When you're done experimenting in the fork, then it can go to the main repo.